Use SQL query API in mission list component#168
Merged
Xiphoseer merged 1 commit intoLUDevNet:mainfrom Apr 6, 2024
Merged
Conversation
Xiphoseer
approved these changes
Apr 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does a bulk query of mission data on the SQL side, including all info from auxiliary tables needed to display a mission/achievement in a mission list, and fetches only what's necessary. This makes large mission pages like
Hidden/Hiddenmuch faster and also massively simplifies the logic in the frontend code. This PR nicely showcases the benefits of the new SQL API - I have a bunch more SQL API PRs in the pipeline that have similar performance increases and code simplifications.